https://bugzilla.wikimedia.org/show_bug.cgi?id=34486
badon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |WONTFIX --- Comment #7 from badon <[email protected]> 2012-02-20 01:56:48 UTC --- I just took a look at the code, and I see what you mean about this not being a bug. Even though I don't follow exactly what's going on, except for the \n\n workaround, it's obvious the code for #formlink wasn't intended to validate the data. I guess maybe you would prefer to call this bug report an enhancement. Either way, the bug/enhancement report is still correct. Being correct means it's not invalid. On to more important issues... {{fullurl:}} and external link syntax can handle query string data more reliably than #formlink, but without some of its features, so for #formlink to be more useful, it needs to work in the same cases. It looks like there's a built-in url-encoding function in PHP: http://php.net/manual/en/function.urlencode.php All that needs to be done is isolate the parameter values, url-encode them, and then return the string. The code for #formlink is in SF_ParserFunctions.php, beginning on line 158 and ending on line 166. I don't understand it much, but I'm guessing the variable that holds the #formlink parameter values is $params. Beyond that, I'm not sure what to do next. Do you have any advice if I want to try figuring out how to fix this? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
