https://bugzilla.wikimedia.org/show_bug.cgi?id=34594

--- Comment #3 from Krinkle <[email protected]> 2012-02-22 15:50:05 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > Is this happening anywhere in production?
> I reported it because I was testing this:
> https://www.mediawiki.org/w/index.php?diff=prev&oldid=502607
> and the toolbar was loaded even if the user disabled that "usebetatoolbar"
> option.

yeah, I merged those two using() calls so that there aren't 2 http requests
made. I was aware of the fact that that means it will load the
wikieditor.toolbar module even if the user doesn't have the toolbar enabled
(rationale: it's better to optimize for those that enable the gadget and have
the wikieditor enabled, than to optimize for the users that enable the gadget
but dont have the wikieditor and thus wont see the effects of the gadget, since
those users shouldn't using that gadget then).

However I did not expect that loading the wikieditor.toolbar module would also
initialize the module, that is indeed a bug.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to