https://bugzilla.wikimedia.org/show_bug.cgi?id=34411

Jeroen De Dauw <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Jeroen De Dauw <[email protected]> 2012-02-23 
16:33:26 UTC ---
r112215

* Please don't prefix stuff with 'm_' or 'm'
* Code style convention for both JS and PHP is to have spaces between round
brackets if there is something in between, so .attr( "id" ) rather then
.attr("id")

I made some changes to the PHP (since the merge failed anyway... looking
foreward to git :). The style mismatch is really trivial, no need to make
another patch for that.

This script allows you to mass fix style issues btw:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/code-utils/stylize.php?view=co

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to