https://bugzilla.wikimedia.org/show_bug.cgi?id=34726

       Web browser: ---
             Bug #: 34726
           Summary: Link "Upload a new version of this file" should be
                    relative
           Product: MediaWiki
           Version: 1.17.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: General/Unknown
        AssignedTo: [email protected]
        ReportedBy: [email protected]
    Classification: Unclassified
   Mobile Platform: ---


The "Upload a new version of this file" link is generated in a non-relative
way, apart of all other links on the same page. This causes several troubles:

Scenario: users access the Wiki through Apache reverse proxy, which translates
HTTPS to HTTP. Users access external address https://wiki.domain.com, and the
proxy forwards requests to http://wiki.internal.local.

Trouble 1: when users open a page with details of uploaded file (like
index.php/File:Document.docx), the "Upload a new version of this file" link is
generated with _internal_ hostname:
http://wiki.internal.local/index.php?title=Special:Upload&wpDestFile=Document.docx&wpForReUpload=1

Of course, users behind the proxy cannot access this link.

Ok, this may be fixed by "ProxyPreserveHost On" instruction on the proxy. But
then comes

Trouble 2: even if the Wiki uses correct external hostname to generate the
link, the _protocol_ still stays http:// and not https://
http://wiki.domain.com/index.php?title=Special:Upload&wpDestFile=Document.docx&wpForReUpload=1

So if the proxy allows HTTPS only, the link is inaccessible again for users.


Proposed solution: very simple. The link should be relative, like the rest.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to