https://bugzilla.wikimedia.org/show_bug.cgi?id=34733

--- Comment #6 from Krinkle <[email protected]> 2012-02-26 19:38:02 UTC ---
(In reply to comment #3)

> BTW: do the function name "postWithEditToken" need to contain the word 
> "Token"?
> Wouldn't be more intuitive if the user didn't have to write that when using 
> the
> API to edit a page? E.g. api.edit( params, ok, err )?

You're right in that postWithEditToken doesn't sound Iike a function that
should be used directly in an application. However the name is good as it is in
my opinion.

It doesn't edit a page by default, it's used as a pre-processor basically to
either continue or get an edit token first. You still need to set action=edit
in the params (or something else). Looks like an mw.Api.prototype.edit function
should be created separate from this that'll call it with action=edit. Not
related to this bug though, create a new enhancement bug for it and a patch if
you like :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to