https://bugzilla.wikimedia.org/show_bug.cgi?id=34853

       Web browser: ---
             Bug #: 34853
           Summary: Shouldn't break ALL gadgets if an unknown dependency
                    is informed in only one of them
           Product: MediaWiki
           Version: 1.19
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: javascript
          Severity: normal
          Priority: Unprioritized
         Component: Resource Loader
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected], [email protected],
                    [email protected]
    Classification: Unclassified
   Mobile Platform: ---


After some reports of broken gadgets on Portuguese Wikipedia, I noticed that
they were failing because one of the default gadgets was defined by
*
Topicon[ResourceLoader|default|dependencies=jquery.mwPrototypes]|Topicon.js|Topicon.css
which worked fine on MW 1.18, and then stoped working on MW 1.19 because the
module was renamed to "jquery.mwExtension" on r94227. This was fixed by
updating the definition:
https://pt.wikipedia.org/w/index.php?title=MediaWiki%3AGadgets-definition&diff=29150779&oldid=29083316

But the point is: the unknown dependency was breaking not only that (default)
script, but other gadgets as well.

You can check this by defining a dummy gadget by means of a line such as
* bug-test[ResourceLoader|dependencies=foo.bar]|bug-test.js
https://pt.wikibooks.org/w/index.php?title=MediaWiki%3AGadgets-definition&action=historysubmit&diff=233968&oldid=233722
and enable it together with some other gadget (e.g. the UTCLiveClock, which is
working fine). There will be an error like this:
> Uncaught Error: Unknown dependency: foo.bar
and the other gadget won't work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to