https://bugzilla.wikimedia.org/show_bug.cgi?id=34302
Antoine "hashar" Musso <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #3 from Antoine "hashar" Musso <[email protected]> 2012-03-05 14:30:39 UTC --- Great! Firstly, you have to add the css to the mediawiki.special.preferences module: Index: resources/Resources.php =================================================================== --- resources/Resources.php (revision 113031) +++ resources/Resources.php (working copy) @@ -786,6 +786,7 @@ ), 'mediawiki.special.preferences' => array( 'scripts' => 'resources/mediawiki.special/mediawiki.special.preferences.js', + 'styles' => 'resources/mediawiki.special/mediawiki.special.preferences.css', ), 'mediawiki.special.recentchanges' => array( 'scripts' => 'resources/mediawiki.special/mediawiki.special.recentchanges.js', You probably forgot resources/Resources.php when making the patch. I don't think we should change the text color, you probably want to keep it black. Have a look at resources/mediawiki.special/mediawiki.special.changeemail.css which apply to a similar case, you can even reuse the colors from there. I don't think you should change the background color of the label but only the input. The CSS should be something like: .mw-email-notverified .mw-input That will leave the label as is. Then the PHP variable holding the css class is using the term "verify" whereas the rest of the code talk about "authentication". Please rephrase $emailverificationclass to $emailAuthClass (we use camel case). Finally the class names are: - mw-email-verified - mw-email-notverified - mw-noemailprefs As above, please considerate using the "authentication" term. Maybe use: - mw-email-authenticated - mw-email-not-authenticated - mw-email-none -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
