https://bugzilla.wikimedia.org/show_bug.cgi?id=35058
Web browser: ---
Bug #: 35058
Summary: [Regression] Don't prepend 2 empty lines before the
Welcome template
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Keywords: code-update-regression
Severity: normal
Priority: Unprioritized
Component: NewUserMessage
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: krinklem...@gmail.com
Classification: Unclassified
Mobile Platform: ---
The extension prepends an empty line before the template, twice.
* One: Presumably in case there is content on the page already, however the
extension doesn't reach this code in that case since it returns early if
$talk->exists(), and even then, it should only insert the new line in case it
exists at point of saving).
* One: To create space between the (optional!) subject header.
This is also causing a visual gap on top of the user talk page:
Example:
*
https://commons.wikimedia.org/w/index.php?title=User_talk:Globatlas_adventures&oldid=68039348
*
https://commons.wikimedia.org/w/index.php?title=User_talk:Globatlas_adventures&action=edit
Proposing to:
* Move the first newline to where it detects the page already exists, away from
the all-case that in (so far) 100% cases is never reached, fixing the first new
line
* Move the second new line to within the if(subject) block, fixing the second
one.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
