https://bugzilla.wikimedia.org/show_bug.cgi?id=35239

       Web browser: ---
             Bug #: 35239
           Summary: Fatal error if to be merged users are blocked
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: Unprioritized
         Component: UserMerge
        AssignedTo: [email protected]
        ReportedBy: [email protected]
    Classification: Unclassified
   Mobile Platform: ---


I get an SQL error that results in a fatal error when merging one blocked user
into another (2 vandals in this case, one is my "Vandal deposit" and the other
has an offensive username).

The SQL error is generated because blocks table can't have 2 entries for the
same user-id (conflicts with the unique pair requirement on the schema).

Not sure what the correct solution is, but it should atleast not crash the
merge and throw an exception.

Suggesting to perhaps query the user with a question ("( ) Preserve the origin
user block / ( ) Preserve the target user block"). Or don't allow such moves
and require them one of them to be unblocked before hand (but that creates an
extra log action that doesn't make sense (unblocking the vandal)).

I think dropping the block on the origin user makes the most sense (when both
are blocked), if only one of them is blocked, then there is no problem. After
the merge the target user is blocked either way.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to