https://bugzilla.wikimedia.org/show_bug.cgi?id=34193

Siddhartha Ghai <siddhartha.g...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |siddhartha.g...@gmail.com

--- Comment #38 from Siddhartha Ghai <siddhartha.g...@gmail.com> 2012-03-25 
19:47:45 UTC ---
(In reply to comment #29)
> [The previous comment was submitted by mistake in a very funny way.]
> 
> The patch looks good to me, in the sense that it doesn't seem to break 
> anything
> major. I also tested in Devanagari on my local wiki and it worked. A test page
> in the live Hindi Wikipedia:
> https://hi.wikipedia.org/wiki/User:Amire80/native_numbers .
> 
> However:
> 1. (Probably) Small problem: It always runs parseFormattedNumber, even when
> that is not needed. Maybe it should run it only on wikis that use such 
> numbers.
> 2. (Somewhat) Larger problem: This is correct if the requirement is to always
> present the result in the native numbers and if it is considered OK to mix
> native and non-native numbers. This may be fine, but is there a specification
> somewhere or is it just a random decision?

Note about the hi-wp subpage that it is set up assuming hi-wp uses devanagari
numerals by default. However, hi-wp has default numerals set to arabic
numerals, hence it is half incorrect. A subpage on hi-wikt for the response
test is [[:w:hi:wikt:User:Siddhartha Ghai/native numbers]]. You'll find that
using arabic numerals gives arabic numerals, using devanagari numerals or
arabic-devanagari mixed gives errors.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to