https://bugzilla.wikimedia.org/show_bug.cgi?id=35060

--- Comment #5 from Derrick Coetzee <[email protected]> 2012-04-05 04:06:56 
UTC ---
Created attachment 10379
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=10379
Adds redirect params to Special:MyPage and MyTalk

Upon reviewing this further, I can imagine plausible use cases for a whole lot
of parameters not currently included in mAllowedRedirectParams:

Current value:
$this->mAllowedRedirectParams = array( 'action' , 'preload' , 'editintro',
                        'section', 'oldid', 'diff', 'dir',
                        'ctype', 'maxage', 'smaxage' );

Parameters listed in
http://www.mediawiki.org/wiki/Manual:Parameters_to_index.php that might be
useful:

useskin, uselang, printable: to alter the appearance of the resulting page

redirect: allows viewing one's user page/user talk page even if it is a
redirect

rdfrom: allows redirecting to one's user page/user talk page from an external
wiki with correct "Redirected from..." notice

limit, offset: Useful for linking to history of one's own user page or user
talk page. For example, this would be a link to "the last edit to your user
talk page in the year 2010":

http://en.wikipedia.org/w/index.php?title=Special:MyPage&offset=20110000000000&limit=1&action=history

feed: Would allow linking to the current user's RSS feed for their user talk
page:

http://en.wikipedia.org/w/index.php?title=Special:MyTalk&action=history&feed=rss

preloadtitle: Came up in an actual use case for me, as mentioned above.

summary: Could be used to provide a default edit summary for a preloaded edit
to one's own user page or talk page.

preview: Allows showing/hiding preview on first edit regardless of user
preference, useful for preloaded edits where you know preview wouldn't be
useful.

internaledit, externaledit, mode: Would allow forcing the use of the
internal/external editor, e.g. to force the internal editor for short/simple
preloaded edits.

redlink: Affects the message the user sees if their talk page/user talk page
does not currently exist. Avoids confusion for newbies with no user pages over
why they got a "permission error" following this link:

http://en.wikipedia.org/w/index.php?title=Special:MyPage&redlink=1

stable: When the FlaggedRevisions extension is installed, allows the link to
determine whether the user sees the stable or draft version of their user
page/user talk page.

debug: Not mentioned on the page, but needed by one of the commenting users.

I've attached a patch against MW 1.18.2 which enables all of these in
mAllowedRedirectParams for both the user and user talk page, attached. Used a
static function to share the list, which is kind of ugly, there's probably a
better way. Needs review from a dev to make sure these rationales make sense
and there are no security issues I'm unaware of, etc.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to