https://bugzilla.wikimedia.org/show_bug.cgi?id=31173

--- Comment #6 from Krinkle <[email protected]> 2012-04-13 01:22:50 UTC ---
So it turns out the work-around for this for 1.19 is quite ugly and abusing
variables (may be unintentional due to the unfortunate naming of the
variables).

Right now neither wgResourcesPath or wgResourcesDirectory has been added to
core. And not in a live hack to 1.19wmf1 or 1.20wmf1 either.

The current 1.19wmf1/1.20wmf1 config (accidentally) (ab)uses the variable
$wgResourceBasePath.

$wgResourceBasePath was implemented a while ago although never really  used. It
is an option to override the internal 'remoteBasePath' property default value
of ResourceLoader modules. By default it falls back to $wgScript.

In general this means it applies to everything in root, including tests,
resources, skins and other paths that may be references in a module.

Right now wmf-config (1.19wmf1/1.20wmf1) has a docroot alias named
"resources-{version}", so far so good, except that it points to the
mwversion-target docroot, not to the 'resources' subdirectory. It works fine
but mostly redundant since the default is fine.

Moreover the subpages for `extensions` and `skins` overwrite all that since
wmf-config also set $wgExtensionAssetsPath and wgStyleSheetPath (pointing to
the appropriate version-alias on bits.wikimedia.org). So the few places not
over-over-overwritten left that use wgResourceBasePath (some embedded icons in
html and locally linked ./resources) don't make use of bits.wikimedia.org
caching.

So proposing to either:
* Implement $wgResourcesPath and $wgResourcesDirectory
* Use them everywhere in core, no hardcoded links to ./resources left, just
like we do with extensions, skins and uploads already
* Remove the weird resources-version=>versiondocroot alias on wmf-config
* Instead add one from resources-version=>versiondocroot/resources

Or:
* Make broader use of $wgResourceBasePath like "wgResourceBasePath/resources",
"wgResourceBasePath/skins", "wgResourceBasePath/extensions"
* Phase out extensionassets/skinsstylepath variables
* Which means we only need 1 alias for resources from now on instead of all
these separate ones (e.g. ./stuff-1.20/skins ./stuff-1.20/extensions and
./stuff-1.20/resources on bits.wm.o and on the other domains)

Not sure which is better or maybe an alternative solution?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to