https://bugzilla.wikimedia.org/show_bug.cgi?id=35875

--- Comment #12 from Krinkle <[email protected]> 2012-04-14 03:01:06 UTC ---
Okay so to remove the support for <source enclose=div> (which could previously
be set manually from wikitext), these lines would have to change in
SyntaxHighlight_GeSHi.class.php:

before:
        // Override default enclose from "enclose" attribute?
        $enclose = $pre;
        if ( isset( $args['enclose'] ) ) {
            if ( $args['enclose'] === 'div' ) {
                $enclose = GESHI_HEADER_DIV;
            } elseif ( $args['enclose'] === 'none' ) {
                $enclose = GESHI_HEADER_NONE;
            }
        }
after:
        // Override default enclose from "enclose" attribute?
        $enclose = $pre;
        if ( isset( $args['enclose'] ) ) {
            if ( $args['enclose'] === 'none' ) {
                $enclose = GESHI_HEADER_NONE;
            }
        }

and that would fix it mostly, however there is still the case where
line-numering are enabling and then geshi will force a <div> still because of
XHTML restrictions (no table allowed in <pre>), which makes perfect sense. So
it looks like we'll have to fix this from mediawiki instead and provide a class
we can use to give pre-styling.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to