https://bugzilla.wikimedia.org/show_bug.cgi?id=18719





--- Comment #3 from Happy-melon <[email protected]>  2009-05-08 19:22:59 UTC 
---
In goes:

...
$sk->link( SpecialPage::getTitleFor( 'Book', "{$action}_article/" ),
           wfMsgHtml( "coll-{$action}_page" ),
           array( 'onclick' => "collectionCall('{$uaction}Article',
['{$action}page', wgNamespaceNumber, wgTitle, $oldid]); return false;",
                  'rel'     => 'nofollow',
                  'title'   => wfMsgHtml( "coll-{$action}_page_tooltip" ), ),
                  $params,
                  array( 'known', 'noclasses', 'noescape' )
         );
...

Out comes:

...
<a
href="/w/index.php?title=Special:Book/add_article/&amp;arttitle=Quok&amp;oldid=0"
title="Add the current wiki page to your book"
onclick="collectionCall(&#039;AddArticle&#039;, [&#039;addpage&#039;,
wgNamespaceNumber, wgTitle, 0]); return false;" rel="nofollow">Add page to
book</a>
...

(This is a rewrite of trunk/extensions/Collection/Collection.hooks.php, which
currently uses loads of <<EOLs and hardcodes just about everything).  I guess
the real issue is that what's being passed to onclick is not actually HTML, but
JavaScript, and should be treated as such.  But that's a bit of a big ask.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to