https://bugzilla.wikimedia.org/show_bug.cgi?id=23172
Max Semenik <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected], | |[email protected] --- Comment #6 from Max Semenik <[email protected]> 2012-04-19 16:27:01 UTC --- A few comments on patch: * static function is being called non-statically * Unneeded strict comparison * Wrong spacing I've fixed them in the new patch. However, the main problem with this fix is that it defeats the point of $wgCleanSignatures by cleaning problematic signatures regardless of it. Adding to CC Tim Starling who originally introduced this setting at Wikia's request - Tim, will this change break anything for them? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
