https://bugzilla.wikimedia.org/show_bug.cgi?id=18735
Summary: Cleanup Collection.hooks.php (patch)
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Keywords: need-review, patch
Severity: enhancement
Priority: Normal
Component: Collection
AssignedTo: [email protected]
ReportedBy: [email protected]
Created an attachment (id=6101)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=6101)
against r50336, refactors collection.hooks.php
While effective and functional, this code is not as well integrated with
MediaWiki's coding conventions or architecture as it could/should be. This
patched version is, I hope, more so. I've cleaned up some unused variables and
globals, rewritten the hardcoded HTML output to use Xml::tags(), Linker::link()
and $wgOut->addScriptFile(), and fixed some double escaping in the tooltips
(bug18719, thanks to Niklas Laxström for pointing that one out). I confess
I'm not 100% certain I've got the script loads correct, as I'm not entirely
sure what script does what. Everything I tested worked as it should :D
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
