https://bugzilla.wikimedia.org/show_bug.cgi?id=36115

       Web browser: ---
             Bug #: 36115
           Summary: Anon users can't change the quality at ProofreadPage
                    extension anymore
           Product: MediaWiki extensions
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: Unprioritized
         Component: ProofreadPage
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]
            Blocks: 35925
    Classification: Unclassified
   Mobile Platform: ---


After all the changes to Proofread Page Extension in 1.20wmf1 anon users can't
change the quality of an page anymore. The main problem are the changes from
proofreadPageUserName to mw.config.get( 'wgUserName' ) in proofreadpage.js. For
anons the proofreadPageUserName was the IP (x.x.x.x) [1] but the wgUserName
outputs null for IP users [2]. This causes problems inside the
proofreadpage_body.php because it blocks when the ip user performs his request.
(Hopefully this is the only problem.)

Another problem is the position of the quality input boxes for anon users. See
the proofreadpage.js [3] at the function pr_add_quality_buttons, specially at
the lines 949-957 (with the extrem sibling action). Get the div with the class
editCheckboxes and append the span child there is much easier and works for all
usergroups (it is default set and for anon it is only empty).

Anon users have the right to change the quality of a page on de.ws per Bug
27516

[1] http://de.wikisource.org/w/index.php?diff=1792330
[2] http://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Page-specific
[3]
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ProofreadPage.git;a=blob;f=proofread.js;hb=ebd197c9f78afae1d2c21cca21fa5df474d80897

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to