https://bugzilla.wikimedia.org/show_bug.cgi?id=36049
Arthur Richards <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #2 from Arthur Richards <[email protected]> 2012-04-20 23:16:25 UTC --- Platonides brought up an excellent point in code review in regards to an oversight I made when doing: if ( !empty( $this->mParams['placeholder'] ) ) { $attribs['placeholder'] = $this->mParams['placeholder']; } He said: "What if the placeholder was a 0 ?" This should probably be handled with isset() rather than !empty(). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
