https://bugzilla.wikimedia.org/show_bug.cgi?id=34453
Carl Austin Bennett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #4 from Carl Austin Bennett <[email protected]> 2012-04-22 14:31:03 UTC --- The original [[mw:extension:PageCSS]] has its code in version control, not on-wiki. The on-wiki code is a pointless fork of this code to [[mw:extension:NewPageCSS]]. We shouldn't have to fork code like this just for one trivial bugfix. As such, I've re-opened this to request the one-line fix in SVN that was needed two months ago (or needed since MW 1.18 came out last year). http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/PageCSS/PageCSS.php still returns nothing from the final routine public static function CssHook::parse() and needs to return the empty string. This needs to be fixed in SVN (and git if this code turns up there, which so far it has not). As for htmlspecialchars(""), that makes no difference either way - constant input will give constant output in this case - but we do need to return *something*, anything, even if it is an empty string or this will give UNIQ...QINU rubbish in the rendered output on MW 1.18+. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
