https://bugzilla.wikimedia.org/show_bug.cgi?id=35145
--- Comment #22 from Chad H. <[email protected]> 2012-04-24 01:31:26 UTC --- (In reply to comment #21) > (In reply to comment #20) > > I missing something here? > Yes. > > Changes can't simply be committed and pushed (since we don't have our own > public remotes like on github but submit patches for review on master). They > must be committed and then "git -review"ed. For that the gitreview file needs > to be installed via pip. See > http://www.mediawiki.org/wiki/Git/Workflow#Windows > or https://labsconsole.wikimedia.org/wiki/Help:Git#Windows > > Since gerrit doesn't work without the git review file, the installation is > necessary. This is not true. You can skip git-review entirely by doing `git push origin HEAD:refs/for/master` but typing `git review` is easier. Also, `git review -s` makes downloading and installing the pre-commit hook easier. But really, git-review isn't *required* for anything. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
