https://bugzilla.wikimedia.org/show_bug.cgi?id=36348
Daniel Friesen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mediawiki-bugs@nadir-seen-f | |ire.com --- Comment #1 from Daniel Friesen <[email protected]> 2012-04-30 03:08:20 UTC --- base64 encoded truncated md5? Not really what I'd pick for 'short' or 'intuitive'. The string concatenation instead of modifying $attribs smells of bad coding style. But more importantly. Taking over the <h#>'s id="" for this? That is a fairly short sighted decision. We have bugs open requesting that we move the existing id="" from the mw-headline to the <h#>. So I would reject this patch simply on those grounds. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
