https://bugzilla.wikimedia.org/show_bug.cgi?id=36310
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.20.0 release --- Comment #5 from Krinkle <[email protected]> 2012-05-03 01:00:31 UTC --- Hm.. So I can reproduce it on en.wikipedia.org (1.20wmf1 at the moment). However it doesn't happen on mediawiki.org (1.20wmf2), but it *does* occur on meta.wikimedia.org (also 1.20wmf2). Doesn't appear to be version related. The problem is that wgHtml5 is still false on most wikis (such as en.wikipedia and meta.wikimedia, but mediawiki.org has wgHtml5 enabled). And since maxlength="" attribute is next for <textarea> in HTML5, MediaWiki strips it from textarea#wpReason on en.wiki and meta.wikimedia causing the problem. The reason this wasn't in 1.19 is because wpReason was changed from an <input> to a <textarea> in 1.20. And maxlength="" is supported on <input> before HTML5, but not on <textarea>. The javascript written for it here https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki.special/mediawiki.special.movePage.js;h=68c2ed078e98b87c3bd29794c67d6036b2577553;hb=HEAD .. was written in 1.19 and assumes (and could assume) that there is a maxlength attribute on both elements, except that in 1.20 #wpReason will not have a maxlength attribute on it when wgHtml5=false, because it is stripped from <textarea> So there's 2 bugs (one is visible now, the other will be visible when the first is fixed) * jquery.byteLimit needs to verify that the value is above zero * We need to hardcode the limit in mediawiki.special.movePage.js instead of assuming the html will contain it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
