https://bugzilla.wikimedia.org/show_bug.cgi?id=34345
Jack Phoenix <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|patch-need-review |patch-reviewed Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Jack Phoenix <[email protected]> 2012-05-04 16:23:44 UTC --- Hi Edward! Firstly, I'm terribly sorry about the delay. I've been busy in real life and with other online projects, so I've kinda forgotten about Bugzilla and reviewing patches. Sorry! That being said, I took a look at your patch and improved it a bit and committed it to SVN in r115137. In addition to changing indentation (we use tabs for indentation, not spaces), I got rid of the deleteComment() function in favor of constructing a Comment object in wfDeleteComment and calling setCommentID() there. I also added some permission checks to wfDeleteComment, so that blocked users not users without the 'commentadmin' permission cannot delete comments by callng that function manually. I moved the question mark into the 'comment-delete-warning' i18n message from the JS file because "Lego" construction of i18n is considered bad practise. The reason why the 'comment-block-warning' does that is because it has a parameter -- that parameter is either 'comment-block-anon', or 'comment-block-user', followed by the name of the person we want to block. Ugly and hacky, but this extension predates ResourceLoader. Thanks for fixing a pretty major and annoying bug, Edward! :-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
