https://bugzilla.wikimedia.org/show_bug.cgi?id=36603
--- Comment #4 from [email protected] 2012-05-07 22:09:46 UTC --- (In reply to comment #2) > The change was introduced > by commit ab6e54e0 https://gerrit.wikimedia.org/r/#/c/6089/ > > We will have to update the Dump tests to [...] Yes sure ... blame it on the messenger^Wtest ;) The code accessing ExportProgressFilter::$sink comes right from adding checkpoint files (git commit bc3caf7666385cd4b4238dbba64a8defb1732d03, lines 575ff of maintenance/dumpTextPass.php): # nasty hack, we can't just write the chardata after the # page tag, it will include leading blanks from the next line $this->egress->sink->write("\n"); which was split off into maintenance/backupTextPass.inc:717ff some time ago. No need to modify the tests. The culprit was setting the visibility of ExportProgressFilter::$sink to protected. Luckily enough the test caught this problem before it hit us on production. Yay for continuous integration and unit testing :D -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
