https://bugzilla.wikimedia.org/show_bug.cgi?id=14323





--- Comment #11 from Brad Jorsch <b-jor...@northwestern.edu>  2009-05-14 
13:40:41 UTC ---
(In reply to comment #10)
> Created an attachment (id=6117)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6117) [details]
> Better patch, against r50568
> 
> Tested my original patch; as I expected, it did indeed render the
> "#REDIRECT[[Foo]]" in plaintext underneath the 'proper' redirect.  I stole the
> code from Title::newFromRedirectInternal to remove the code from the 
> wikitext. 
> A better solution would be to have the Parser replace the #REDIRECT marker 
> with
> Article::viewRedirect when it encounters it, but this method works. Patch
> tested and works for normal display, however for some reason it does not 
> render
> the page contents on page preview, which is a bit wierd.

One criticism: "#REDIRECT [[foo]] {{bar}}" renders as " {{bar}}" rather than
"{{bar}}", which means the template output is rendered in <pre></pre> tags.
That will be a problem on enwiki, as many redirects still follow the pre-r12339
rule. Perhaps either "\s*" or " *" (depending on whether you want to eat blank
lines or just the problematic spaces) should be added to the end of your regex?

Other than that, it seems to work well.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to