https://bugzilla.wikimedia.org/show_bug.cgi?id=36753
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #5 from Krinkle <[email protected]> 2012-05-11 08:43:43 UTC --- (In reply to comment #3) > It looks like there's a race condition between mediawiki.action.edit.js and > http://en.wikipedia.org/wiki/MediaWiki:Common.js/edit.js (which is loaded from > MediaWiki:Common.js). In theory, mediawiki.action.edit.js is supposed to load > after MediaWiki:Common.js/edit.js. > The problem is a simple one. When taken as-is, the answer is simple. It can't be fixed. The global variable mwCustomEditButtons is just a variable. It can't be "hook"'ed into for changes. Either one checks it in time or it is checked too late. To my knowledge this has always been an issue, for as long as the classic toolbar exists. Users have always been struggling with load event handlers to time it just right for their own browser. The only way to fix it is to not use the (now deprecated) mwCustomEditButtons variable but the new (well, not very new anymore) mw.toolbar object instead. See also bug 33952 and related bugs. I've already informed en.wikipedia in the past about this: * https://en.wikipedia.org/wiki/MediaWiki_talk:Common.js/edit.js#MediaWiki:Common.js.2Fedit.js:_Opt-out * https://en.wikipedia.org/wiki/MediaWiki_talk:Common.js/edit.js#MediaWiki:Common.js.2Fedit.js:_mw.toolbar.addButton *** This bug has been marked as a duplicate of bug 33952 *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
