https://bugzilla.wikimedia.org/show_bug.cgi?id=30803
--- Comment #9 from Krinkle <[email protected]> 2012-05-25 03:26:34 UTC --- Looking at this patch again, I think this is becoming too complex for a simple utility function that gets the url of a page name. There is handling for all of this already in the mw.Uri module and also integrated with the mw.Title module. mw.util is a arbitrary/simple utilities, of which most really belong in a separate module. Adding features like this means re-inventing wheels that have already been polished in other modules. The Uri and Title modules aren't all that big but do their job really well (including handling for hash fragments, which you mentioned), so if you need something like this in your code, I'd say just use those modules directly and be done with it. I see your patch also contains handling for action paths, which is nice. I'm not sure if mw.Title / mw.Uri support that right now. If it makes sense to have there, that would be great to have! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
