https://bugzilla.wikimedia.org/show_bug.cgi?id=20595
Vitaliy Filippov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Vitaliy Filippov <[email protected]> 2012-05-25 10:28:22 UTC --- There is another example - 5 minute limit for "too many incorrect password attempts" never expires! The problem is that default BagOStuff::incr() implementation doesn't preserve TTL of cache keys. SQL and memcache are OK, as they are implementing incr() themselves. It's easy to fix for APC and XCache as there are underlying apc_inc() and xcache_inc() methods. eAccelerator didn't have increment method in previous versions... And now it doesn't have variable cache at all :-D also it doesn't work with PHP 5.4, so I think it doesn't matter if it will work. So, only DBA and Ehcache are left. DBA stores TTL with the key, so it's also easy to fix incr() for it. Don't know what Ehcache and its API is slightly more complex to check for increment quickly. I'll probably make and push the fix for APC, XCache and DBA to gerrit. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
