https://bugzilla.wikimedia.org/show_bug.cgi?id=37138

       Web browser: ---
             Bug #: 37138
           Summary: Search not working correctly on the "Database error"
                    page (Google sitesearch doesn't support protocol
                    relative urls)
           Product: Wikimedia
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: General/Unknown
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: krinklem...@gmail.com
    Classification: Unclassified
   Mobile Platform: ---


Both the `domains` and the `sitesearch` query parameters are currently
protocol-relative. Google only allows naked hostnames or full hostnames with
protocol.

We should probably be passing the canonical server there.

Dump:

<!-- SiteSearch Google -->
<form method="get" action="//www.google.com/search" id="googlesearch">
    <input type="hidden" name="domains" value="//commons.wikimedia.org" />
    <input type="hidden" name="num" value="50" />
    <input type="hidden" name="ie" value="UTF-8" />
    <input type="hidden" name="oe" value="UTF-8" />

    <input type="text" name="q" size="31" maxlength="255" value="" />
    <input type="submit" name="btnG" value="Search" />
  <div>
    <input type="radio" name="sitesearch" id="gwiki"
value="//commons.wikimedia.org" checked="checked" /><label
for="gwiki">Wikimedia Commons</label>
    <input type="radio" name="sitesearch" id="gWWW" value="" /><label
for="gWWW">WWW</label>
  </div>
</form>
<!-- SiteSearch Google -->

Example url from submitting "test" with "Commons Wikimedia":

https://www.google.com/search?domains=%2F%2Fcommons.wikimedia.org&num=50&ie=UTF-8&oe=UTF-8&q=test&btnG=Search&sitesearch=%2F%2Fcommons.wikimedia.org

(which just searches the entire web)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to