https://bugzilla.wikimedia.org/show_bug.cgi?id=424

--- Comment #33 from Krinkle <[email protected]> 2012-05-27 23:44:22 UTC ---
(Review of attachment 10384)
>Index: ./phase3/includes/ChangesList.php
>===================================================================
>--- ./phase3/includes/ChangesList.php  (revision 112982)
>+++ ./phase3/includes/ChangesList.php  (working copy)
>@@ -103,7 +103,7 @@
>        */
>       private function preCacheMessages() {
>-                      foreach ( explode( ' ', 'cur diff hist last blocklink 
>history ' .
>+                      foreach ( explode( ' ', 'cur diff hist last blocklink 
>history unwatch ' .

i18n file uses "watchlist-toollink-unwatch" but here it says "unwatch". Please
make it match and update the array access (->['unwatch']) as well


>       public function insertDiffHist( &$s, &$rc, $unpatrolled ) {
>+              global $wgUser;

No need for the global anymore. In the current git master ChangesList.php has
been updated to use Context. Below you can pass $this->getUser() directly to
the UnwatchAction method.

>+                              'action' => 'unwatch',
>+                              'token' => UnwatchAction::getUnwatchToken( 
>$rc->getTitle(), $wgUser )
>+                      )
>+              );

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to