https://bugzilla.wikimedia.org/show_bug.cgi?id=36094
MZMcBride <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #4 from MZMcBride <[email protected]> 2012-06-02 03:05:38 UTC --- (In reply to comment #2) > (In reply to comment #1) > > That preference doesn't exist in trunk > > It's in an extension (cf. > <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114004>). At what point > was Wikimedia's git branch for this extension created? > > And more generally, I'm not sure how user prefs are set from an extension. Do > you use https://www.mediawiki.org/wiki/Manual:$wgDefaultUserOptions or some > other method? So it looks like r114004 got reverted by r114398. Then the Git migration happened. Then Reedy moved the JS to the modules directory in this rev: <https://gerrit.wikimedia.org/r/6340>. That's where they are now. Looking at <https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ProofreadPage.git;a=blob;f=modules/ext.proofreadpage.page/ext.proofreadpage.page.js;h=8de9532b7e9e8813211ca076ae20efdbdba05b03;hb=a86dd67fbecea2078cc81badd8222ed05499f876> and <https://bits.wikimedia.org/en.wikisource.org/load.php?debug=true&lang=en&modules=ext.proofreadpage.page&only=scripts&skin=monobook&*>, we can see that the following code is present currently: --- if ( mw.user.options.get( 'proofreadpage-showheaders' ) ) { pr_reset_size(); } else { pr_toggle_visibility(); } --- So this bug is largely invalid. Local Wikisource administrators should continue to use Common.js or a user JavaScript gadget (preferably a gadget) to override this on a site-wide or per-user basis. If/when the code from r114004 is pulled into Git, this bug can be re-opened or a new bug can be filed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
