https://bugzilla.wikimedia.org/show_bug.cgi?id=18844
--- Comment #10 from Aryeh Gregor <[email protected]> 2009-05-19 22:26:36 UTC --- That's less than a 5% difference doing *nothing else*. It's *less than a millisecond*. It would probably sink to more like 0.5% of the entire page save process, a negligible gain. On the other hand, you're removing functionality, whether or not it may be unused at present. Still recommend WONTFIX. (In reply to comment #9) > So that's less than a 5% difference, absolute difference of 7ms in the test > case (151 vs 158ms total). That's 15.8 vs 15.1 ms total -- a difference of 0.7 ms, or 700 us. > The 'spambl' file seems to be missing from the test > case archive, so I can't reproduce results locally. It's created by running run-tests, which also runs the benchmark. On localhost I get about the same results (~1ms difference, 5% gain). > Is functionality unchanged with the switch to nongrouping, or would this > require changing other components? Functionality is reduced -- it's no longer possible to use back-references. It also gives the Principle of Least Surprise a severe smack on the head (who would expect something to take raw regexes and then change their functionality weirdly?). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
