https://bugzilla.wikimedia.org/show_bug.cgi?id=12701
--- Comment #29 from Lupo <[email protected]> 2012-06-06 22:26:06 UTC --- In any case, it appears Aaron had begun implementing this back in 2008. At least he added a user_last_timestamp column to table user_newtalk (see r33520 and two follow-ups r83137 and r854185). But that appears to be all; I don't see that Db field used anywhere. With this field present, it is, however, relatively simple to implement the feature requested here. (Although the name is a bit awkward: one cannot store the time the user last viewed his or her talk page there, as that's when the row is deleted, but it needs to store the timestamp of the first revision made after the user last saw his or her talk page.) But given that nothing happened for 3 - 4 years on this issue, I'd like to have some input from Aaron or Roan as to whether that is still desired. If so, I could invest some time to do this. Also, there's two issues here on which I'd like to have Roan's or Aaron's input: - First, counting revisions as "number of messages" as Ahmad did in his patch strikes me as patently incorrect. Consider the same editor amending his last message: that's two revisions, but one message. Or a vandal editing a talk page and getting reverted: 2 revisions, zero messages. So I'd prefer to not attempt counting revisions or messages at all, but just go for the plural in the "(last change)" part, which then becomes "(last changes)" and a diff to the correct revision, as originally suggested. - Second, Roan said in comment 19 that there was only one row per user talk page in table user_newtalk. That may have been the intention (the code does an INSERT IGNORE), but that's not what really happens. The table gets a new row for each revision. The reason is, I think, that the table is lacking a primary key; it should have a PRIMARY KEY (user_id, user_ip). I would suggest adding such a primary key. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
