https://bugzilla.wikimedia.org/show_bug.cgi?id=34590
--- Comment #27 from Platonides <[email protected]> 2012-06-08 14:19:32 UTC --- Doesn't look too bad. I see a number of coding style issues: use tabs not spaces for identation, place spaces around text in brackets. Don't include Start Patch / End patch markers. The translations are not needed at all, but as you already have them, it can probably be imported on translatewiki. My main concern is that you're implementing this in User::idFromName(). I'd move that logic to a new function User::idFromEmail() or User::idFromEmailOrName() I'd probably make a User::newFromEmail() and call that on SpecialUserlogin.php line 533 if what was provided is an email. For User::newFromEmail() you can just copy loadFromDatabase() with a different select condition. It will only be happning on login, so we can load the full row at once. Also, a new function would fix the case where the email isn't a safe title (and it gets rejected in line 480, before checking the email). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
