https://bugzilla.wikimedia.org/show_bug.cgi?id=25984
--- Comment #9 from Platonides <[email protected]> 2012-06-09 12:19:02 UTC --- Yes, it is hacky :) Some ideas: - Indent with tabs, not spaces. - If you add a new global, it has to be defined in DefaultSettings - Names like hackTriggered are fine for your code, but would carry no meaning if it were integrated upstream. - Instead of downloading from a web server, load from the filesystem. Check for ../ attacks. (Ideally, there would be different classes depending if it was db-backed or filesystem-based) - Wikipage::checkForDownloadingHack() should return itself the (cached) content, instead of manually doing the $this->downloadedContent - No need to hack Parser::fetchTemplateAndTitle(), that can be redirected through setTemplateCallback(). - Why do you need to change EditPage, if you're not doing page editing? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
