https://bugzilla.wikimedia.org/show_bug.cgi?id=35212

--- Comment #10 from kipod <[email protected]> 2012-06-11 16:53:55 UTC ---
(In reply to comment #9)
> I've gone ahead and submitted Kipods tipsy version after testing.
> https://gerrit.wikimedia.org/r/#/c/9962/

as this patch does not meet the expected gerrit standards, it was rejected.
at the very least, it should be broken into 3 seperate pieces:

1) merge upstram changes
2) fix the upstream bugs
3) add new functionality (i.e., support "hovertip" for trigger parameter).


ideally, before or after #2 there should be some more changes: 

2.5) reformat code to adhere with mediawiki coding standrard (yuck - spaces
after "(" and before ")" ?  disgusting), and add some comments to better
document the code.

as indicated, this depends on bug #35241 (taking over tipsy maintenance), which
 is still up in the air.

peace.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to