https://bugzilla.wikimedia.org/show_bug.cgi?id=32128

--- Comment #35 from Sumana Harihareswara <[email protected]> 2012-06-12 
18:10:08 UTC ---
https://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fextensions%2FOnlineStatusBar&title=Special%3ACode%2FMediaWiki
has the updates and code review Krinkle has done, and we'll be moving the
extension to Gerrit this week.  Useful bits of IRC conversation from today:


<TrevorParscal> I just OK'd Timo's whitespace fixes
<TrevorParscal> I think this extension is ready to be moved to gerrit
personally
<Krinkle> yeah, we both did a review and a small pass with fixes over the code.
afaik it is fully reviewed and fixed up. I did open 1 or 2 bugs in bugzilla
that I think have to be fixed before deployment on production wikis
<Krinkle> they block deployment of any kind imho, but moving the repo into
gerrit is fine
<TrevorParscal> it's gone through UI review (by me) and UI fixup (by petr),
JS/CSS rewrite (by me( and JS/CSS review (by Timo) and PHP review (by me and
Timo) and fix up (by Petr and Timo) and finally more review (by me)
<^demon> Let's get it on the list so it'll get done this week.
<Krinkle> TrevorParscal: I didn't put this in review or in bugzilla, but
something else I dislike about it is how it displays the information "John Doe
is now <blib> offline" or "John Doe is now <blib> hidden" or "John Doe is now
<blib> status is unknown"
<TrevorParscal> Krinkle: yeah, I suggested that the <blip> be moved to the far
right and the sentence be more consistent

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to