https://bugzilla.wikimedia.org/show_bug.cgi?id=36938
--- Comment #4 from Sam Reed (reedy) <[email protected]> 2012-06-14 13:54:04 UTC --- (In reply to comment #3) > The fix for this appears to cause a couple of PHP Notices (at least on > 1.17.5): > > Notice: Undefined variable: userlang in [..]/includes/SkinTemplate.php on line > 327 > Notice: Undefined variable: userdir in [..]/includes/SkinTemplate.php on line > 328 > > This is on a Russian-language wiki with my user language set to English. > > The lines concerned are intended to set the lang and dir attributes . . . > > $lang = $wgLang->getCode(); > $dir = $wgLang->getDir(); > if ( $lang !== $wgContLang->getCode() || $dir !== $wgContLang->getDir() ) { > $escUserlang = htmlspecialchars( $userlang ); << HERE > $escUserdir = htmlspecialchars( $userdir ); << HERE > // Attributes must be in double quotes because htmlspecialchars() doesn't > // escape single quotes > $attrs = " lang=\"$escUserlang\" dir=\"$escUserdir\""; > $tpl->set( 'userlangattributes', $attrs ); > > It looks like $lang and $dir were renamed to $userlang and $userdir in 1.18; > the patch for 1.17 should be corrected to refer to $lang and $dir. https://gerrit.wikimedia.org/r/11284 Also note, 1.17 is due to go EOL this month. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
