https://bugzilla.wikimedia.org/show_bug.cgi?id=18890
Steve Sanbeg <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #11 from Steve Sanbeg <[email protected]> 2009-05-27 23:44:59 UTC --- I agree that the div seems kludgy; rather than recommend littering the output with hidden divs, it would be better to recommend putting the newlines where the extension can control them; i.e. <ref hide name=h0> def for h0 </ref><ref hide name=h1 > def for h1 </ref><ref hide name=h2 > def for h2 </ref> I also think the "define" might be a better term than "hide", conceptually that it's defining text to be used elsewhere. For that, I think this patch is more complex than necessary. It should be sufficient to define/override the text without incrementing the usage count for the footnote, rather than generating bogus instances, and keeping track of which uses shouldn't be there, so <references> can filter them out. It would also be better if some of the nonsensical cases (i.e. multiple, anonymous, missing text, etc) produce errors, for better consistency with the rest of the extension. Finally, you should look at the parser tests (see the script in the maintaneance directory & file included with the extension) both to verify that you didn't cause any new regressions, as well as to add your own test cases as examples there, since you are changing the syntax. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
