https://bugzilla.wikimedia.org/show_bug.cgi?id=38189

--- Comment #3 from MZMcBride <[email protected]> 2012-07-05 07:53:46 UTC ---
(In reply to comment #1)
> This is because you're missing the rcid parameter.  This is required for
> marking a page patrolled.

I don't think this is strictly true. Looking at the "Mark this page as
patrolled" link on Meta-Wiki (specifically here:
<https://meta.wikimedia.org/w/index.php?title=Wikimedia_Highlights,_February_2012/fi&redirect=no&rcid=3377713>),
it includes a (pre-filled) token parameter. For example, the link I currently
have looks like this:
<https://meta.wikimedia.org/w/index.php?title=Wikimedia_Highlights,_February_2012/fi&action=markpatrolled&rcid=3377713&token=8db654c84c7c9ec5221fb5a3966aaf63%2B%5C>.
I believe the token URL parameter is the key missing element here. The token
parameter looks like a protection against nefarious GET requests.

Looking at [mediawiki/core.git] / includes / actions / MarkpatrolledAction.php
seems to confirm this:

---
        $user = $this->getUser();
        if ( !$user->matchEditToken( $request->getVal( 'token' ), $rcId ) ) {
            throw new ErrorPageError( 'sessionfailure-title', 'sessionfailure'
);
        }
---

Source:
<https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/actions/MarkpatrolledAction.php;h=ae9223f45783ced6dc89c76e7cd5af85bb375535;hb=540dfed2a6e42cbd6f761014f9213f311022458a>.

> You really shouldn't be attempting to automatically mark pages patrolled
> anyway.

I don't think this is the bug here, though I do agree that this bug sounds
invalid. People trying to mark pages as patrolled ought to use MediaWiki's API:
<https://www.mediawiki.org/w/api.php> (search for "action=patrol"). The token
parameter will still be required via the API, however. You can retrieve it
using list=recentchanges, according to the docs.

(Hmm, the token parameter isn't marked as required, though. Hmmmm.)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to