https://bugzilla.wikimedia.org/show_bug.cgi?id=38234
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from [email protected] 2012-07-08 08:44:14 UTC --- Short answer: First URL hits a bug in the code, but this bug is now partly fixed in a new version. Any fatal bugs due to faulty program flow may result in bugs producing any kind of formats, including but not limited to free text. In addition you use language as site ids, which should have be catched but this module bypasses validity checks. Your call in this case is flawed. Second URL tries to make a duplicate entry. This was allowed in some cases previously, but is not allowed anymore. Long answer: The function of wbsetitem is mostly undocumented and undefined, and may in the future include additional validation of the arguments. For the moment _all_ actions that includes json passed to this module is a feature but unsupported and may go away. ;) The servers may, or may not, run in a debug mode where GET requests are allowed. If they are allowed the GET requests are limited in length. When they are limited in length they will be truncated. When they are truncated they will fail because the json will be invalid and the call to json_decode will fail. The code is currently missing several checks on validity when transitioning from a json structure and to a item structure (which is basically a json structure itself). The reason why it is so is because this module tries to map a json-structure to an array structure representing an item. Later this array structure is recreated as a json structure in the item itself and as rows in special tables in the database structure. The mappings from json to the array are not well-defined, and especially the handling of requests that somehow violates the existing constraints are not defined at all. Note that json used as input to wbsetitem is _not_ the same as the json you get as output. In my opinion _all_ calls that violates _any_ constraint should fail. Especially note that the repo does important normalization and validation when called through wbsetsitelink, and that those are bypassed when you use wbsetitem. It is highly likely that the same normalization and validation will be enforced in wbsetitem. First call reads something like http://wikidata-test-repo.wikimedia.de/w/api.php?action=wbsetitem&format=xml&item=add&data= { "label":{ "en":{"language":"en","value":"Sina"}, "de":{"language":"de","value":"Sina"}, "la":{"language":"la","value":"Sina"}, "fy":{"language":"fy","value":"Sina"}, "nl":{"language":"nl","value":"Sina"}, "mg":{"language":"mg","value":"Sina"} }, "links":{ "en":{"site":"en","title":"Sina"}, "de":{"site":"de","title":"Sina"}, "la":{"site":"la","title":"Sina"}, "fy":{"site":"fy","title":"Sina (betsjuttings)"}, "nl":{"site":"nl","title":"Sina"}, "mg":{"site":"mg","title":"Sina"} } } It should be http://wikidata-test-repo.wikimedia.de/w/api.php?action=wbsetitem&format=xml&item=add&data= { "label":{ "en":"Sina", "de":"Sina", "la":"Sina", "fy":"Sina", "nl":"Sina", "mg":"Sina" }, "links":{ "enwiki":"Sina", "dewiki":"Sina", "lawiki":"Sina", "fywiki":"Sina (betsjuttings)", "nlwiki":"Sina", "mgwiki":"Sina" } } First form is invalid after a previous change of the internal transform from an array to the internal json structure. It does not fail due to bypassed validation checks, but it should fail. Second call reads something like http://wikidata-test-repo.wikimedia.de/w/api.php?action=wbsetitem&format=xml&item=add&data= { "label":{ "en":{"language":"en","value":"ABC"} }, "links":{ "en":{"site":"en","title":"ABC"} } } It should be http://wikidata-test-repo.wikimedia.de/w/api.php?action=wbsetitem&format=xml&item=add&data= { "label":{ "en":"ABC" }, "links":{ "enwiki":"ABC" } } -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
