https://bugzilla.wikimedia.org/show_bug.cgi?id=38888
--- Comment #10 from Daniel Werner <[email protected]> 2012-07-31 20:32:57 UTC --- I have fixed mentioned stuff in https://gerrit.wikimedia.org/r/17113 - Chad: > Rather than checking for the HTTP_USER_AGENT to see if it's a web request, it would be better to see if php_sapi_name() != 'cli' I just remembered that I can simply use $wgCommandLineMode now. A global implying whether tests are running currently would be nice though. - Reedy: > Why are we using isset on a global? and > Is there any point adding pre 1.16 compatibility? I guess not, except if you consider people copying that \Ext class for their own extensions who support compatibility. I copied this from one of my other extensions. But now I altered it to not use $wgExtensionAssetsPath for all cases. $wgExtensionAssetsPath is only set to false during LocalSettings, and that is where we would require it already. The cleanest solution for all of that resource loader registration stuff would probably be if it would require a $wgExtensionAssetsPath relative path... - Bawolff: > Well extension has moved... good point, just fixed that path as well. > How does this interact with squid caching? First, this extension causes cache fragmentation, so we have one version of each language in the parser cache. If I am not mistaken, it should be possible for squid caching to still be active, it might even work with the current setup. > Anon users get a big list of default preferred languages. The moment you log > in (at least on http://wikidata-test-repo.wikimedia.de which is where I'm > testing this from) the list of preferred languages goes to nothing. The > default preference should be the same as what logged out users get imo. We thought about that, but decided against it at some point. The point was, that displaying the largest 10 Wikipedias languages would significantly increase the chance of more anon users finding their language immediately. For logged in users on the other hand, it is very unlikely that one user speaks all of those languages, we just know the user knows the language which is chosen as its interface language, so we pre-select that one as default instead. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
