https://bugzilla.wikimedia.org/show_bug.cgi?id=36400

--- Comment #7 from Brad Jorsch <[email protected]> 2012-08-03 
15:42:39 UTC ---
(In reply to comment #3)
> The first part of your patch makes the query unindexed:
> * Was: iwl_prefix = const, ORDER BY iwl_title, iwl_from - covered by index
> iwl_prefix_title_from
> * Your patch: iwl_prefix = const, ORDER BY iwl_from, iwl_title - no suitable
> index.

I forgot to update the bug until now, but I talked to Roan at the Berlin
Hackathon two months ago and we concluded that the query in my patch is
correct, and we should have a iwl_prefix_from_title index to cover it (keep
iwl_prefix_title_from, ApiQueryIWBacklinks uses that).

The other possibility we considered was changing the processing of the continue
parameter so ORDER BY iwl_title, iwl_from would be correct for that case. The
problem there is inconsistency: if the module needs to return
(prefix,title,from) triplets of ('de','foo',1), ('de','bar',1), and
('de','bar',2), and the API limit is 1, it would return page_id 1 with link
de:bar, then page_id 2 with link de:bar, then page_id 1 again with link de:foo.
All other API modules that return results by page like this would return
page_id 1 with link de:bar, then page_id 1 with link de:foo, and only then
page_id 2. Some clients may depend on this behavior.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to