https://bugzilla.wikimedia.org/show_bug.cgi?id=38009

--- Comment #6 from Arthur Richards <[email protected]> 2012-08-16 
15:46:31 UTC ---
Thanks for all the contributions - and nice hacks! I was going to suggest that
we add some javascript to delete the cookie when the 'Mobile view' link gets
clicked. This could be added to the MobileFrontend code so it gets loaded on
the desktop version of the site via ResourceLoader.

The code that was added to common.js does not appear to be working, at least
for me. In fact, it looks like it's setting an additional cookie, which is
really just going to cause more problems for people. I didn't dig into this too
deeply but I suspect it's because the path and/or domain of the cookie being
set in common.js does not match that of the initially set stopMobileRedirect
cooki. I made some quick modifications and this appears to work (from
User:Awjrichards/common.js):

mw.loader.using( 'jquery.cookie', function() {
    $('a[href$="toggle_view_mobile"]').click(function(){
        $.cookie( 'stopMobileRedirect', false, 'Thu, 01-Jan-1970 00:00:00 GMT',
'/' );
    });
});

There have been a number of changes in MobileFrontend that negatively affected
how the toggling cookies work, plus we've had extra complications with the
cluster's caching infrastructure. But the solution you all came up with is
pretty much exactly what I would've done - now let's just get it into
MobileFrontend! Are any of you interested in making a patch to get this little
bit of js loaded on the desktop view? This will help alleviate problems for the
other sites as well.

I apologize that this is something that has gone unfixed for so long - we've
had our hands full with other work that has been given higher priority and we
have not had the chance to get this resolved. But for me, this shows how
awesome the project and open source software in general is. It was broken, and
you fixed it :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to