https://bugzilla.wikimedia.org/show_bug.cgi?id=38622
--- Comment #16 from Daniel Kinzler <[email protected]> 2012-08-22 17:02:56 UTC --- Thanks for your comments Tim. I have addressed some of the issues you mentioned in my recent commits to gerrit. I have self-approved some cosmetic changes, others are pending review - could you have a look? https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+branch:Wikidata+is:open,n,z In particluar, I have done the following: * cleaned up long lines * addressed, removed or reworded many FIXME and XXX comments * implemented ContentHandler::runLegacyHooks, and made use of it in several places, cleaning up crufty code. The changes in DairikiDiff where made in order to make this class more flexible and reusable by by other kinds of content. I still think that would be nice, but it's not needed for Wikibase/Wikidata, since we ended up implementing our own Diff infrastructure. So, this is what I'll do: * revert the changes to DairikiDiff * make sure the DifferenceEngine is created via the revision's ContentHandler, not the Title's. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
