https://bugzilla.wikimedia.org/show_bug.cgi?id=30625
Derk-Jan Hartman <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #14 from Derk-Jan Hartman <[email protected]> 2012-08-25 10:42:26 UTC --- Wow, there is just a multitude of issues here it seems. First there seems to be code in the initial upload step to check for duplicates. HOWEVER 1: I suspect the warning is actually encountered in setTransported(), and an error is set, but the logic probably overrides this with setSuccess afterwards. No feedback is ever provided and the upload seems just fine You'll want something like: if (warnings.duplicate) (or duplicate-archive) var dupeFile = warnings.duplicate[0]; "This file is already available as [[File:dupeFile]]." vs. for archived "This file was previously available as [[File:setTransported]]". "Remove upload/Continue" 2: The archive error was not handled in the final step https://gerrit.wikimedia.org/r/21405 3: The duplicate errors should be ignored in the final step, just as was-deleted (which means you picked a title that previously has existed). 4: The .showError() of UploadDetails is simply non-recoverable. It does not allow you to remove the file that is problematic, and esp. for unknown errors, that is bad. I should allow you to remove the upload so you can continue the other uploads in your list. 5: The .showError() does not surface the 'Continue' and/or "Upload more files" buttons. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
