https://bugzilla.wikimedia.org/show_bug.cgi?id=39717

--- Comment #4 from Brion Vibber <[email protected]> 2012-08-28 03:02:25 UTC 
---
Thumbs for complete and incomplete uploads are done very differently, so it may
be best to split this into two bugs:

Completed upload thumbnails are loaded via ImageFetcher:
* first load the thumbnail URLs via an API request
* then, for each image load it into an offscreen Image object
* as each image completes loading, resolve() the deferred...
 - caller hides the spinner and loads the thumb URL into an <img/> element in
the document, which shows the now-cached thumbnail

Either something's getting lost and not hooked up to the deferred object, or
the image is failing to load and the Image's onload event never gets called, so
we never resolve the deferred with either a reject or resolve.

A network error breaking the thumbnail load might do this perhaps...


Incomplete upload thumbnails are generated differently, but with some similar
elements:
* load each full-size local image file into an offscreen Image object
* as each image completes loading, draw it into a <canvas/> element at
thumbnail size and replace the spinner image

An actually physically missing image might leave the onload handler not
hitting, but .... this ought not happen? Hm. :(

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to