https://bugzilla.wikimedia.org/show_bug.cgi?id=27493
--- Comment #3 from Krinkle <[email protected]> 2012-08-29 01:27:25 UTC --- For one, we need to decide which one to use. The one linked in the bug is a fork of jeresig[1], but that is a 3-year old fork of a repository where he made 2 commits to fix a jquery 1.4.2 bug. We probably want to use the original instead which has been maintained throughout the years and was last updated 3 months ago for jQuery 1.7.1. And the original includes John Resig's changes (https://github.com/tzuryby/jquery.hotkeys/commit/2bc49e96bfed711244ceb0fc64b28f2c5b49900c) [1] https://github.com/jeresig/jquery.hotkeys/commits [2] https://github.com/tzuryby/jquery.hotkeys/commits Though there's a change in tzuryby's version. It uses namespaces to pass on which key to listen for. So instead of: $(el).on( 'keypress', 'esc', fn ); or: $(el).on( 'keypress', { key: 'esc' }, fn ); it now uses: $(el).on( 'keypress.esc', fn ); That seems rather cripple in my opinion, not sure why anyone would want that or why they changed it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
