https://bugzilla.wikimedia.org/show_bug.cgi?id=38450
--- Comment #7 from Richard Guk <[email protected]> 2012-09-03 22:23:41 UTC --- (In reply to comment #6) > These should be filed as separate bugs, please. :-) Sorry to be feeble, but with the myriad of related bugs and your greater knowledge of whether my report amounts to zero, one or two bugs, I'd be grateful if you could file whatever consequential bug reports are appropriate. > Right. But does a "valid" oldid behave as you expect? Yes, if the "oldid" value refers to a (past or current) revision ID that exists. The problem is that any other "oldid" value (in the absence of any "title") returns info about the main page instead of returning an error, so readers may not realise that they have made a mistake. Note: I have not tested the handling of revdeleted IDs. > I think you're hitting a > differently (underlying) issue (i.e., that ?action=info doesn't support > oldid's). Whether accidentally or by design, "oldid" values are correctly mapped to the current revision of the relevant page when oldid matches a revisionid, as expected. But, unlike the robust "curid" handling, "oldid" fails to degrade gracefully by returning an error message (instead of data for the main page) if there is no matching revision ID. > "Invalidtitlehere" isn't an invalid title. :-) Elephant! Rephrasing: If the "title" parameter (or the canonical /wiki/Baz:Foo_bar URL) does not refer to a page that exists, action=info should return an error page, instead of the misleading garbage edit history data that it currently returns. >From a non-coder's perspective, even if you consider the above parameters to be unsupported and unworthy of attention, the inconsistent failure responses hint that poor internal validation may lead to unexpected results or unintended information disclosure in more complex scenarios. Or, to put it more positively: strong validation checks would save confusion when the functionality is rolled out more widely. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
