https://bugzilla.wikimedia.org/show_bug.cgi?id=40020
--- Comment #3 from Chad H. <[email protected]> 2012-09-05 19:11:39 UTC --- (In reply to comment #2) > So am I supposed to write "See inline." every time I write inline comments if > I > want IRC notification to work properly? > Unless someone improves the hooks further to distinguish between the two cases, yes. This has been the case for quite some time now. Having to include a cover message is mildly annoying, but I considered it an acceptable tradeoff at the time to silence the gerrit spam from +1s with no comment, and the even more annoying +2/Submit spam when someone approves & submits in one step with no comment (we only need one notification of the submit, not an empty +2 as well). The hook stuff is not gerrit code, it's something we wrote and maintain in the puppet repo. The files are all in files/gerrit/hooks/*. I welcome improvements to it and would be more than happy to review them, but I probably won't personally revisit the issue for awhile. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
